[esp-r] possible mistake in BCL15?

[Leen Peeters]

Dear all,

In the BCL15 zone-controller (in bcfunc.F on line 4242), there is a user
input requested to set the initial trial test time. It indicates '1' for
"user defined" and '2' for "set equal to 4 hours". However, in the code
on line 4309 these '1' and '2' are linked differently;
      if(initim.eq.2)then
         stinit=4.    
      else if(initim.eq.1)then
         stinit=bmiscd(icf,idtyp,iper,8)

 I think they should be switched to ;
      if(initim.eq.1)then
         stinit=4.    
      else if(initim.eq.2)then
         stinit=bmiscd(icf,idtyp,iper,8)

On line 4355;
C IF FIRST PASS, SET INITIAL TRIAL START TIME,
      if(lgctin.eq.1.and.irwcnt.eq.0)then
        stpres=stinit
      endif  

C SAVE PRESENT VALUES,
      if(lgctin.eq.1.and.irwcnt.gt.irwcsv)then
         stpas2=stpas1
         stpas1=stpres
         stpres=stfut
         irwcsv=irwcnt
      endif
is a loop that will never be entered, as there is no counter to increase
lgctin and its initial value is 0. Shouldn't it be replaced by;
C IF FIRST PASS, SET INITIAL TRIAL START TIME,
      if(lgctin.eq.0.and.irwcnt.eq.0)then
        stpres=stinit
        lgctin=lgctin+1
      endif  

C SAVE PRESENT VALUES,
      if(lgctin.NE.0.and.irwcnt.gt.irwcsv)then
         stpas2=stpas1
         stpas1=stpres
         stpres=stfut
         irwcsv=irwcnt
         lgctin=lgctin+1
      endif

Thanks,
Leen

Disclaimer: http://www.kuleuven.be/cwis/email_disclaimer.htm